-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Ensure non-root container images. #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d50030b to
cee859a
Compare
|
Check work. Now we have to wait and rebase until all upstream projects release the non-root container images. |
cee859a to
517d8c0
Compare
517d8c0 to
7023284
Compare
|
STAC Browser 4.0.0 includes the change: https://github.com/radiantearth/stac-browser/releases/tag/v4.0.0 |
|
Yes, STAC-Browser 4.0.0 is part of #376 |
aa9314e to
3b4e0e0
Compare
| initContainers: | ||
| - name: wait-for-pgstac-jobs | ||
| image: alpine/k8s:1.28.0 | ||
| image: bitnami/kubectl:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use this one? Should it not be bitnamilegacy/kubectl:<something>?
Either way, I'd say ⛔ to bitnami.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works. Even without the legacy part.
As far as i know this is the only (serious) one that runs as non-root. Maybe we should stick to alpine/k8s but use securityContext with it?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. I'm not convinced when deployed, it will work, but not sure, maybe kubectl is a rare case of bitnami truly keeping it free..
|
All services are running now as non-root, but |
447d2dd to
3b4e0e0
Compare
6f0a6fe to
25dc65d
Compare
3b4e0e0 to
a8abf21
Compare
a8abf21 to
e211b95
Compare
Closes EOEPCA/resource-discovery#163